Repository navigation
[Buganizer ID: 570296338 ]Migrate Batch 11: ElasticSearchV7 - #1304
Open
Arabindaksha-Mishra wants to merge 13 commits into
Open
Arabindaksha-Mishra wants to merge 13 commits into
Arabindaksha-Mishra wants to merge 13 commits into
Conversation
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' |
Arabindaksha-Mishra
changed the title
Arabindaksha-Mishra
changed the title
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' |
…istorical RN publish_time for compare_rebuilt_to_original parity
sachinspatil-contenthub
previously requested changes
Oct 27, 2026
sachinspatil-contenthub
left a comment
sachinspatil-contenthub
left a comment
Contributor
There was a problem hiding this comment.
Migration review: ElasticSearchV7 (elastic_search_v7)
Diffed against tip-marketplace/Integrations/ElasticSearchV7 (GoB v22.0 → 23.0) and repo conventions. Parity is mostly solid — all 4 actions / 2 connectors / 4 managers present, Python diffs are import-only, CaseInfo correctly imported from soar_sdk.SiemplifyConnectorsDataModel, action params, widgets, JSON examples and ontology_mapping.yaml match GoB, uv.lock is in sync and urllib3 stays on 1.26.x.
The must-fix items are anchored inline: three Verify SSL defaults flipped vs GoB, the dropped DefaultProductToFamilies mapping, the unrelated COMMUNITY_INDEX.json change, the per-integration ruff override, and the merge-order dependency on #1414.
PR hygiene (no file to anchor)
- The description says
integration-testingis a dependency and thatconftest.pyusesintegration_testingfixtures — neither is in the PR. That's actually correct for a TIPCommon-1.0.11 integration (integration_testingneeds TIPCommon ≥ 2.0), so please fix the description rather than the code. - Body says
Buganizer ID: 495762513, title says570296338— please align. - The checklist ticks "tagged with labels" but the PR has none; please add
migration. - Please add "Depends on #1414" (see inline comment on
actions/Ping.py).
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' | |
| Actions with JSON results missing example files in resources/: SimpleESSearch, AdvancedESSearch, DSLSearch | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v1: '', v2: '' |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' | |
| Actions with JSON results missing example files in resources/: AdvancedESSearch, DSLSearch, SimpleESSearch | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v1: '', v2: '' |
… standardize uv index
…ishra/marketplace into migration_ElasticSearchV7
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' | |
| Actions with JSON results missing example files in resources/: AdvancedESSearch, DSLSearch, SimpleESSearch | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v1: '', v2: '' |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' | |
| Actions with JSON results missing example files in resources/: AdvancedESSearch, DSLSearch, SimpleESSearch | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v1: '', v2: '' |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report
|
| Validation Name | Details |
|---|---|
| New integration project.toml and release_note.yaml version must be initialize to 1.0 | |
| elastic_search_v7: Ping success message must contain: 'Successfully connected to the'; Ping failure message must contain: 'Failed to connect to the' | |
| Actions with JSON results missing example files in resources/: AdvancedESSearch, DSLSearch, SimpleESSearch | |
| Release notes have invalid publish_time values (expected YYYY-MM-DD): v1: '', v2: '' |
aketki
requested changes
Nov 5, 2026
aketki
approved these changes
Nov 5, 2026
Arabindaksha-Mishra
dismissed
sachinspatil-contenthub’s stale review
November 6, 2026 19:46
Solved all and got approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the ElasticSearchV7 integration from the legacy GoB repository (tip-marketplace) to the open GitHub repository (content-hub).
Deconstruction: Migrated source code into modular
actions/,core/,resources/, andwidgets/structure with standardized relative imports for Chronicle SOAR packaging.Dependencies: Configured
pyproject.tomlanduv.lockwith required runtime and development dependencies (tipcommon,environmentcommon,soar-sdk, andintegration-testing).Tests: Configured test suite with
integration_testingfixtures inconftest.py, modernized mock paths, and mock session fixtures.Validation: Verified with
mp check,mp validate,mp test, andmp build.Tracking:
Buganizer ID: 495762513
Batch: Batch 11
Checklist:
Please ensure you have completed the following items before submitting your PR. This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only: