Repository navigation
Conversation
Soft-deleted collections can retain compaction failures, including failures recorded by compactions that finish after deletion. Exclude them from the DLQ metric so they cannot trigger false growth alerts. Cover deletion from shared and unique buckets, failures after deletion, and an empty live DLQ in the collection DAO regression test. Co-authored-by: AI
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
davedash
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
A compaction that finishes after its collection is soft-deleted can increment the collection's failure count and trigger the compaction DLQ growth alert.
GetDLQFailureCountsincluded these deleted collections indefinitely until physical cleanup.Exclude
is_deleted = truecollections from the DLQ metric query. This corrects existing inflated counts as well as failures recorded after deletion. Compactor retry behavior is unchanged.The production count rose from 23 to 24 immediately after a
collection soft deletedcompaction failure on October 9. Honeycomb failure history.Test plan
TestCollectionDb_GetDLQFailureCountspasses against PostgreSQL via OrbStack.go test -race ./pkg/sysdb/metastore/db/dao -run '^TestCollectionDbTestSuiteSuite$' -count=1(withDOCKER_HOSTset to the OrbStack socket).Migration plan
No schema migration or data cleanup required. Deploy the Go sysdb service; the next metric observation excludes existing soft-deleted collections.
Observability plan
Monitor
compaction_dlq_sizeand the "Compaction failures spreading to more collections" alert after deployment. Counts may decrease as deleted collections are excluded.Documentation Changes
Clarify that
GetDLQFailureCountscounts live collections. No public API changes.