Repository navigation
fix: retry errored repos per collection hook (#502) - #576
Open
eelasyot-spec wants to merge 1 commit into
Open
eelasyot-spec wants to merge 1 commit into
eelasyot-spec wants to merge 1 commit into
Conversation
A backlog of new repos in one stream no longer blocks Error retries in others.
| success = CollectionState.SUCCESS.value | ||
|
|
||
| return ( | ||
| f"UPDATE collection_status SET {status_col} = '{pending}'" |
Codecov Report❌ Patch coverage is
Additional details and impacted files🚀 New features to boost your workflow:
|
Contributor
Docker is currently the only supported method of installing/running CollectOSS Also please signoff your commits |
MoralCode
reviewed
Nov 17, 2026
|
|
||
|
|
||
| @pytest.mark.unit | ||
| def test_build_error_retry_sql_core_resets_pending_and_success(): |
Contributor
There was a problem hiding this comment.
What problem would be detected if this test fails?
Can we document this for each test? As we add more tests itll start to get really busy and we should make sure to document what each test is intended to indicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backlog of new repos in one stream no longer blocks Error retries in others.
Description
retry_errored_reposused a single global check: if any collection hook had a new-repo backlog, Error retries were skipped for every hook. That left errored secondary/facade/ml work stuck whenever core (or another stream) still had pending new repos.This PR evaluates the new-repo backlog per hook. Idle hooks reset their Error repos (never-collected → Pending; previously collected → Success) while busy hooks still skip retries so they are not overwhelmed. Helpers live in
collection_util.py; unit tests cover the ready-hook selection and per-hook SQL.This PR fixes #502
Notes for Reviewers
retry_errored_repos(it previously logged undercreate_collection_status_records).Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? Cursor (Composer)
- How were these tools used? Implementation of the per-hook retry logic, helper extraction, and unit tests; also drafting this PR description.
- Did you review these outputs before submitting this PR? Yes — reviewed the behavior against #502, confirmed unit tests pass, and verified the SQL/status rules match the previous all-hooks path.
Made with Cursor