Repository navigation
fix(file-utils): match file extensions case-insensitively in getFileMimeType - #3505
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 19005b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue; found while reading the source.
📝 Description
getFileMimeTypelooks up the file extension inmimeTypesMapas is, but the map keys are lowercase. Files with an uppercase extension get no mime type.⛳️ Current behavior (updates)
isValidFileTypeusesgetFileMimeTypewhenfile.typeis empty (e.g. HEIC photos on Windows/Chrome, or files from some drag-and-drop sources). So withaccept="image/*",IMG_0001.HEICis rejected whileimg_0001.heicis accepted. Extension accepts like.pngalready ignore case, so only mime accepts are affected.🚀 New behavior
IMG_0001.HEICresolves toimage/heicand passesaccept="image/*".@zag-js/file-utils.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
get-file-mime-type.test.tsand one new case inis-valid-file-type.test.ts. Both fail onmainand pass with the fix.vitest run packages/utilities packages/machines/file-upload: 808 passed, 1 skipped.tsc --noEmitandeslint src testspass for the package, andtsupbuilds it.