Repository navigation
fix(number-input): mirror scrubbing direction in rtl - #3504
Merged
segunadebayo merged 1 commit intoOct 21, 2026
Merged
Conversation
getMousemoveValue flipped the hint with two sequential checks. Under dir="rtl" the first turned "increment" into "decrement" and the second turned it straight back, while "decrement" became "increment". Dragging the scrubber either way always incremented the value. Swap the hint in a single step. Fixes chakra-ui#3503 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 1b8f851 The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3503
Description
The RTL flip in
getMousemoveValueused two sequential checks, so the second undid the first. Underdir="rtl"scrubbing in either direction incremented the value.Current behavior
In RTL, dragging the scrubber left or right always increments.
New behavior
dircontrol to the number input examples and an e2e test that scrubs both ways in RTL. It fails onmainand passes with the fix.scrubBynow takes negative offsets.@zag-js/number-input.Is this a breaking change (Yes/No):
No
Additional Information
main. Number input typecheck and lint pass.