Repository navigation
fix(date-picker): select the focused date with Space - #3500
Merged
segunadebayo merged 3 commits intoOct 21, 2026
Merged
Conversation
The calendar table keydown handler mapped Enter to TABLE.ENTER but had no Space entry. The day, month and year cell triggers are elements with role="button", not native buttons, so the browser does not turn Space into a click either. Pressing Space on a focused date did nothing, although the WAI-ARIA date picker dialog pattern lists Space and Enter as the keys that select the date and close the dialog. Map Space to the Enter handler, as menu, select and listbox do. Fixes chakra-ui#3499 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d184d2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3499
Description
The date picker table handled Enter but not Space, and the cell triggers use
role="button"rather than native buttons, so Space on a focused date did nothing. The APG date picker dialog pattern selects the date with either key.Current behavior
Space on a focused date, month or year cell does nothing.
New behavior
keyMap.Enter?.(event)pattern as menu, select and listbox.date-picker/basicthat selects today with Space. It fails onmainand passes with the fix.@zag-js/date-picker.Is this a breaking change (Yes/No):
No
Additional Information