Repository navigation
fix(editable): let a rendered label name the input - #3498
Merged
Merged
Conversation
The input always set aria-label from the translations, which default to "editable input". aria-label takes precedence over a native label in accessible name computation, so a rendered Label part was ignored and the input was announced as "editable input". Track whether the label is rendered and only fall back to the default aria-label when it is not. An explicit translations.input still wins. Fixes chakra-ui#3495 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: f487cbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3495
Description
The editable input always set
aria-labelfrom the translations, which default to "editable input".aria-labelbeats a native<label>in accessible name computation, so a rendered Label part never named the input.Current behavior
With a Label rendered, the input is announced as "editable input".
New behavior
aria-labelonly applies when no label is rendered. An explicittranslations.inputstill wins.@zag-js/editable.Is this a breaking change (Yes/No):
No
Additional Information
Editable e2e tests pass on React (12 of 12). Editable typecheck and lint pass.