Repository navigation
fix(tour): restore focus when the tour is dismissed - #3497
Merged
Merged
Conversation
The tour traps focus in its content while a step is open, with returnFocusOnDeactivate turned off so focus does not jump back between steps. Nothing restored focus when the tour ended, so dismissing it with Escape, the close trigger or skip left focus on the body. Remember the focused element when the tour starts and focus it again on dismiss or skip, unless the user already moved focus elsewhere. Fixes chakra-ui#3496 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d6e4ad1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 85 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3496
Description
The tour focus trap turns off
returnFocusOnDeactivateso focus does not jump back between steps. Nothing restored focus when the tour ended, so dismissing it left focus on the body.Current behavior
After Escape, the close trigger or skip, focus is on
<body>.New behavior
@zag-js/tour.Is this a breaking change (Yes/No):
No
Additional Information
Tour e2e tests pass on React (15 passed, 3 skipped as before). Tour typecheck and lint pass.