[tests] Run the distributed locks on fakeredis - #1233
Merged
Merged
Conversation
The CI provides no Redis. redis_lock opens a fresh client and pings it on every lock: each playlist, annotation or cache single-flight lock in a test waited for redis-py's connection retries (about ten seconds) before falling back to the unlocked mode, and the locks themselves were never exercised. - Point redis_lock.get_redis_client at a fakeredis in the test base, flushed after each test like the other fake stores. - Install fakeredis with its lua extra: redis-py's Lock releases through a Lua script. - Cover the lock exclusivity and the per-key independence. Without Redis the full suite drops from 22 to under 10 minutes locally. Tests: tests/stores/test_redis_lock.py, full suite without Redis (3128 passed, known ffmpeg-version failure in test_movie aside) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
alone took 112 s instead of 2 s
Solution