Refactor iridium_server session and rpc parser for SRP - #37
Conversation
- Extracted `execute_sql` and batch logic from `TdsSession` into `execution.rs`. - Extracted handshake and login logic into `handshake.rs`. - Refactored `tds::rpc::parser.rs` into a module directory with `types.rs`, `utils.rs`, and `parser.rs`. - Validated via `cargo test` and `cargo check`. Core parsers in `iridium_core` remain un-split due to tight cross-module trait coupling.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This refactoring targets the largest files in the
iridium_servercrate to bring them closer to the Single Responsibility Principle.session/mod.rswas split into execution and handshake concerns, and thetds/rpc/parser.rswas divided by types and utilities. Attempts to splitiridium_corefiles likeexpressions.rsanddml.rswere halted as they require more fundamental architectural changes to break their deep circular dependencies and trait bounds.PR created automatically by Jules for task 6438927531929406537 started by @celsowm