Skip to content

Implement security and file system stored procedures for SQL Server 2025 parity - #35

Merged
celsowm merged 1 commit into
mainfrom
sql-server-2025-sp-parity-9664337799192887219
Apr 20, 2026
Merged

Implement security and file system stored procedures for SQL Server 2025 parity#35
celsowm merged 1 commit into
mainfrom
sql-server-2025-sp-parity-9664337799192887219

Conversation

@celsowm

@celsowm celsowm commented Apr 20, 2026

Copy link
Copy Markdown
Owner

This PR implements several key system stored procedures required for SQL Server 2025 compatibility, specifically focusing on security and file management metadata.

Changes included:

  • Implementation of sp_helpuser, sp_helprole, sp_helprolemember, sp_helpsrvrole, sp_helpsrvrolemember, sp_helpfile, and sp_helpfilegroup.
  • Addition of the sys.server_role_members virtual table.
  • Enhancement of sys.server_principals to include default server roles like sysadmin.
  • Updates to docs/sql-server-2025-implementation-status.md to reflect newly implemented features.
  • Comprehensive integration tests in crates/iridium_core/tests/sql_server_2025_parity.rs.

PR created automatically by Jules for task 9664337799192887219 started by @celsowm

…rver 2025 parity

Implemented sp_helpuser, sp_helprole, sp_helprolemember, sp_helpsrvrole,
sp_helpsrvrolemember, sp_helpfile, and sp_helpfilegroup in system_procedures.rs.
Added sys.server_role_members virtual table and updated sys.server_principals
to support these procedures. Updated implementation status documentation and
added comprehensive tests in sql_server_2025_parity.rs.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@celsowm
celsowm merged commit ac8f597 into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant