Skip to content

Implement SQL Server 2025 Parity Features (Group 1) - #34

Merged
celsowm merged 1 commit into
mainfrom
sql-server-2025-parity-group1-3615242221267019679
Apr 20, 2026
Merged

Implement SQL Server 2025 Parity Features (Group 1)#34
celsowm merged 1 commit into
mainfrom
sql-server-2025-parity-group1-3615242221267019679

Conversation

@celsowm

@celsowm celsowm commented Apr 20, 2026

Copy link
Copy Markdown
Owner

Implemented two major groups of SQL Server 2025 parity features:

  1. Index and Constraint Enhancements: Added CLUSTERED, NONCLUSTERED, and FILLFACTOR support. Updated the SchemaExecutor to honor these flags during table creation and index rebuilding.
  2. Logic and Expression Refinements: Added COALESCE, NULLIF, and LIKE ... ESCAPE. The LIKE matching now uses a dynamic programming approach to correctly handle escaped wildcards.
  3. Session and Identity Management: Implemented SET IDENTITY_INSERT enforcement in the MutationExecutor and wired the IDENTITYCOL keyword into the identifier resolution logic.
  4. Type System Parity: Enhanced parse_data_type to handle ISO-standard synonyms like CHARACTER VARYING and NATIONAL prefixes.

The catalog::ColumnDef and ast::ColumnSpec structures were expanded to include collation and is_clustered fields, with all relevant initializers updated across the engine. All changes are verified with new parity tests in tests/sql_server_2025_parity.rs.


PR created automatically by Jules for task 3615242221267019679 started by @celsowm

- Add support for CLUSTERED and NONCLUSTERED index/constraint keywords.
- Implement FILLFACTOR index option parsing and catalog storage.
- Add COALESCE and NULLIF as reserved keywords with built-in mapping.
- Implement LIKE ... ESCAPE syntax and DP matching algorithm.
- Support ISO types: CHARACTER VARYING, DOUBLE PRECISION, and NATIONAL.
- Implement SET IDENTITY_INSERT enforcement and IDENTITYCOL resolution.
- Update catalog and AST structures to support collation and clustering.
- Resolve 40+ structural stabilization issues across binder and executors.
- Update implementation status documentation.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@celsowm
celsowm merged commit 30e4429 into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant