Implement SQL Server 2025 Parity Features (Group 1) - #34
Conversation
- Add support for CLUSTERED and NONCLUSTERED index/constraint keywords. - Implement FILLFACTOR index option parsing and catalog storage. - Add COALESCE and NULLIF as reserved keywords with built-in mapping. - Implement LIKE ... ESCAPE syntax and DP matching algorithm. - Support ISO types: CHARACTER VARYING, DOUBLE PRECISION, and NATIONAL. - Implement SET IDENTITY_INSERT enforcement and IDENTITYCOL resolution. - Update catalog and AST structures to support collation and clustering. - Resolve 40+ structural stabilization issues across binder and executors. - Update implementation status documentation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implemented two major groups of SQL Server 2025 parity features:
CLUSTERED,NONCLUSTERED, andFILLFACTORsupport. Updated theSchemaExecutorto honor these flags during table creation and index rebuilding.COALESCE,NULLIF, andLIKE ... ESCAPE. TheLIKEmatching now uses a dynamic programming approach to correctly handle escaped wildcards.SET IDENTITY_INSERTenforcement in theMutationExecutorand wired theIDENTITYCOLkeyword into the identifier resolution logic.parse_data_typeto handle ISO-standard synonyms likeCHARACTER VARYINGandNATIONALprefixes.The
catalog::ColumnDefandast::ColumnSpecstructures were expanded to includecollationandis_clusteredfields, with all relevant initializers updated across the engine. All changes are verified with new parity tests intests/sql_server_2025_parity.rs.PR created automatically by Jules for task 3615242221267019679 started by @celsowm