Repository navigation
fix: report collector and read failures - #584
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Verification Checklist
go test ./...passes cleanlypython3 plugin/hooks/test_secret_guard.pyand other python hook tests passbash packaging/swift_macos.sh test --package-path menubarpasses./packaging/test/e2e_smoke.shpassesFocused race tests, live guard workflow, lint, documentation checks, and the CGO-disabled build passed.
Broad Go tests failed in
TestSessionReportIntegerOverflowRejectsPartialTotals,TestContentOverFileBoundKeepsSquashAnswer, andTestContentRewrittenHistoryNamesWhatWasMeasured. The Swift suite failed in fiveDaemonSupervisorTests; that class passed separately. Python hook suites and packaging smoke were not run for this change. These unresolved checks keep this PR in draft.