Conversation
# Conflicts: # .github/workflows/plugins.yml # .github/workflows/rspec.yml # .github/workflows/typecheck.yml
The setup-ruby bundler cache is busted by cache-version, so two different values across jobs give those jobs separate caches for no reason. linting.yml already carried 2026-01-11 from master while the ten cache-version entries added here said 2025-06-06. Use master's value everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was written by Claude Code on behalf of @apiology.
Problem: Every CI job rebuilds Solargraph's gem annotation cache and reinstalls the bundle from scratch, because neither is carried between runs.
linting.ymlis the one job that tries, and it cannot work:actions/cache/restoreonly reads, and nothing writes that key.Solution: Promote that step to
actions/cache@v4, whose post-job hook saves the key; add it to the rspec, typecheck and four plugin jobs; and turn onsetup-ruby'sbundler-cacheunder thecache-versionlinting.ymlalready carried.Warm run vs master at the merged commit:
Solargraph / strongrailsrspecregressionrspecmatrix, mean of 17One run each, not a benchmark. Both caches key on
Gemfile.lock, so a dependency change starts cold, and that run is slower than master since it also pays the save.