Conversation
Rules#initialize computed the level by indexing LEVELS (a Symbol-keyed Hash) with LEVELS.values.index(@rank), an Integer. That lookup never matches a Symbol key, so level was always nil at runtime despite being documented to return a Symbol. Use Hash#key(value) instead, the correct reverse lookup from rank back to its level symbol. Adds a regression spec asserting #level returns the expected Symbol.
apiology
marked this pull request as ready for review
August 27, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude:
Problem:
TypeChecker::Rules#level(attr_reader :level, documented@return [Symbol]) has silently returnednilsince it was introduced in 2020 (38e0da2a9, PR #311), and it's public API via the publicattr_readerTypeChecker#rules.LEVELS.values.index(@rank)returns anInteger, and indexing theSymbol-keyedLEVELShash with anIntegernever matches any key.Solution:
Replace the broken reverse lookup with
LEVELS.key(@rank),Hash#key's correct value-to-key lookup, and add a regression spec.