Skip to content

feat: change docker scans - #7122

Merged
krzysztofczyz-da merged 3 commits into
mainfrom
kczyz/docker-scans
Sep 9, 2026
Merged

krzysztofczyz-da merged 3 commits into
mainfrom
kczyz/docker-scans

Conversation

@krzysztofczyz-da

@krzysztofczyz-da krzysztofczyz-da commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

@krzysztofczyz-da krzysztofczyz-da added the static Used to label PRs for which static tests suffice label Sep 4, 2026
@krzysztofczyz-da

Copy link
Copy Markdown
Contributor Author

/cluster_test

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploy cluster test triggered for Commit 6c115d3b9992f4a5dd499ec929767b7d5eee8b3b in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/81285

@krzysztofczyz-da

Copy link
Copy Markdown
Contributor Author

/cluster_test

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploy cluster test triggered for Commit ded5308ede232cc7c10c8191f2579dbe62bb8878 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/81301

@krzysztofczyz-da

Copy link
Copy Markdown
Contributor Author

/cluster_test

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Deploy cluster test triggered for Commit ded5308ede232cc7c10c8191f2579dbe62bb8878 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/81438

@krzysztofczyz-da
krzysztofczyz-da marked this pull request as ready for review September 8, 2026 11:42
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>

@martinflorian-da martinflorian-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we have a more descriptive title + description + perhaps link to some related issue?

Comment thread build-tools/docker-scan

# Ensure the image is available locally. On K8s runners the image is not
# built in the same job, so we need to pull it from the registry first.
docker pull --platform linux/amd64 "$image"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ELI5: we try to use multi-arch images everywhere - why force linux/amd64 here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudn't matter for the scanning and using multi-arch broke the scanner for some reason 😢

@krzysztofczyz-da
krzysztofczyz-da merged commit 4f927d5 into main Sep 9, 2026
43 checks passed
@krzysztofczyz-da
krzysztofczyz-da deleted the kczyz/docker-scans branch September 9, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

static Used to label PRs for which static tests suffice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants