feat: change docker scans - #7122
Conversation
|
/cluster_test |
|
Deploy cluster test triggered for Commit 6c115d3b9992f4a5dd499ec929767b7d5eee8b3b in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/81285 |
|
/cluster_test |
|
Deploy cluster test triggered for Commit ded5308ede232cc7c10c8191f2579dbe62bb8878 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/81301 |
|
/cluster_test |
|
Deploy cluster test triggered for Commit ded5308ede232cc7c10c8191f2579dbe62bb8878 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/81438 |
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
Signed-off-by: krzysztofczyz-da <krzysztof.czyz@digitalasset.com>
ded5308 to
6819a9d
Compare
martinflorian-da
left a comment
There was a problem hiding this comment.
Thanks! Can we have a more descriptive title + description + perhaps link to some related issue?
|
|
||
| # Ensure the image is available locally. On K8s runners the image is not | ||
| # built in the same job, so we need to pull it from the registry first. | ||
| docker pull --platform linux/amd64 "$image" |
There was a problem hiding this comment.
ELI5: we try to use multi-arch images everywhere - why force linux/amd64 here?
There was a problem hiding this comment.
Shoudn't matter for the scanning and using multi-arch broke the scanner for some reason 😢
Part of https://github.com/DACH-NY/canton-network-internal/issues/4566
Needed for https://github.com/DACH-NY/canton-network-internal/pull/3827