Skip to content

Support non-fixed tokens in party allocator - #7120

Merged
moritzkiefer-da merged 1 commit into
mainfrom
cocreature/party-allocator-client-credentials
Sep 7, 2026
Merged

Support non-fixed tokens in party allocator#7120
moritzkiefer-da merged 1 commit into
mainfrom
cocreature/party-allocator-client-credentials

Conversation

@moritzkiefer-da

@moritzkiefer-da moritzkiefer-da commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[static]

Tested by manually applying the image on devnet.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@canton-network-da

canton-network-da commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[backport] Reminder

Please consider backporting to the following branches:

  • release-line-0.7.5
  • release-line-0.7.4
  • release-line-0.7.3
  • release-line-0.7.1

▶️ Please check the boxes for branches that you wish to backport to and backport PRs will
automatically be created when you merge this PR.

And your PR is currently against base branch: main.

Note: Any PR comment containing [backport] will be considered for auto-backporting upon merge,
you can always add those manually for PRs that did not get these reminders. You can also edit
this comment manually and add more branches that this should be backported to.

@moritzkiefer-da
moritzkiefer-da force-pushed the cocreature/party-allocator-client-credentials branch from 988ec4b to e5eb124 Compare September 4, 2026 12:04
@cocreature
Support non-fixed tokens in party allocator
c3f5574 
[static]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da
moritzkiefer-da force-pushed the cocreature/party-allocator-client-credentials branch from e5eb124 to c3f5574 Compare September 4, 2026 12:05
@moritzkiefer-da
moritzkiefer-da marked this pull request as ready for review September 4, 2026 12:05
moritzkiefer-da
moritzkiefer-da commented Sep 4, 2026
View reviewed changes
Comment thread party-allocator/src/auth.ts
}
}

async function getTokenEndpoint(wellKnownConfigUrl: string): Promise<string> {

@moritzkiefer-da moritzkiefer-da Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is probably some library I could be using for this stuff but seemed easier to just inline it especially given that this is test code only anyway

martinflorian-da
martinflorian-da approved these changes Sep 7, 2026
View reviewed changes

@martinflorian-da martinflorian-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@moritzkiefer-da
moritzkiefer-da merged commit d92d393 into main Sep 7, 2026
44 checks passed
@moritzkiefer-da
moritzkiefer-da deleted the cocreature/party-allocator-client-credentials branch September 7, 2026 08:59
@canton-network-da canton-network-da mentioned this pull request Sep 7, 2026
Merged
@moritzkiefer-da moritzkiefer-da mentioned this pull request Sep 7, 2026
Merged
8 tasks
moritzkiefer-da added a commit that referenced this pull request Sep 7, 2026
@canton-network-da @moritzkiefer-da
@cocreature DA Automation
Backport PR #7120 to release-line-0.8.0 (#7149)
604041e 
* Support non-fixed tokens in party allocator (#7120)

[static]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* [static]

Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>

---------

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: DA Automation <splice-maintainers@digitalasset.com>
moritzkiefer-da added a commit that referenced this pull request Sep 7, 2026
@moritzkiefer-da @cocreature
make party allocator version configurable (#7151)
1140083 
[static]

That should allow us to apply
#7120 properly on devnet
before the next release.

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da added a commit that referenced this pull request Sep 7, 2026
@canton-network-da @moritzkiefer-da
@cocreature DA Automation
Backport PR #7151 to release-line-0.8.0 (#7155)
933e196 
* make party allocator version configurable (#7151)

[static]

That should allow us to apply
#7120 properly on devnet
before the next release.

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>

* [static]

Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>

---------

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: DA Automation <splice-maintainers@digitalasset.com>
martinflorian-da pushed a commit that referenced this pull request Sep 10, 2026
@canton-network-da @moritzkiefer-da
@cocreature DA Automation
Backport PR #7155 to release-line-0.8.1 (#7246)
444d2bb 
* Backport PR #7151 to release-line-0.8.0 (#7155)

* make party allocator version configurable (#7151)

[static]

That should allow us to apply
#7120 properly on devnet
before the next release.

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>

* [static]

Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>

---------

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: DA Automation <splice-maintainers@digitalasset.com>

* [static]

Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>

---------

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: DA Automation <splice-maintainers@digitalasset.com>
martinflorian-da pushed a commit that referenced this pull request Sep 10, 2026
@canton-network-da @moritzkiefer-da
@cocreature DA Automation
Backport PR #7155 to release-line-0.8.x (#7247)
27ec51b 
* Backport PR #7151 to release-line-0.8.0 (#7155)

* make party allocator version configurable (#7151)

[static]

That should allow us to apply
#7120 properly on devnet
before the next release.

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>

* [static]

Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>

---------

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: DA Automation <splice-maintainers@digitalasset.com>

* [static]

Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>

---------

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: DA Automation <splice-maintainers@digitalasset.com>
Co-authored-by: moritzkiefer-da <45630097+moritzkiefer-da@users.noreply.github.com>
Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Co-authored-by: DA Automation <splice-maintainers@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinflorian-da martinflorian-da martinflorian-da approved these changes
@isegall-da isegall-da Awaiting requested review from isegall-da
@julientinguely-da julientinguely-da Awaiting requested review from julientinguely-da

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moritzkiefer-da @canton-network-da @martinflorian-da @cocreature