Drop version checks on SV-operator-only paths - #7040
adetokunbo wants to merge 3 commits into
Conversation
0f81f0f to
34c88cf
Compare
ca6e096 to
01800b0
Compare
01800b0 to
d2c38d7
Compare
There was a problem hiding this comment.
I don't think we can remove these checks. Most of these checks are asking "has this random amulet owner vetted at least amulet version X", and we'll have validators/parties that have abandoned the network and are thus forever stuck at some ancient version.
We could remove some of them, for example those only checking the vetting state of SV operators (here assuming they are on a recent version makes more sense), but this has nothing to do with TBAR.
I would close #6388, and reassign the associated TODOs to #1825 (for the dso governance package) or remove them (for all other packages)
d2c38d7 to
cfd4ca2
Compare
|
Ah, understood. I've reverted most of the commits, and only removed the checks in a couple of places that only use
I also changed the TODO target. |
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
cfd4ca2 to
954e0c1
Compare
rautenrieth-da
left a comment
There was a problem hiding this comment.
This PR removes the following helpers:
supports24hSubmissionDelayDsoGovernance: used to check if sv/dso parties support dso governance 0.1.23, which should be true on all networkssupportsPhysicalSynchronizers: used to check if sv/dso parties support dso governance 0.1.24, which should be true on all networks
So the change makes sense to me. @cocreature can you please double check the above?
makes sense to me! |
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines