feat: carry a registration through the wallet buy path - #27
Open
salindne wants to merge 7 commits into
Open
Conversation
Appends optRegisteredSynchronizer to CO_BuyMemberTraffic and forwards it to AmuletRules_BuyMemberTraffic. Producers pass None until the Scala half lands. Rides splice-wallet 0.1.24, which is built but on no release line. Appending a trailing Optional to a constructor of this variant at an unchanged package version follows 044079a. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
Drops the synchronizerId and migrationId assertions and the header comment. An unregistered synchronizer id fails the buy outright, so the test cannot reach those assertions with a mismatch, and the surviving operator check is what binds the forwarding: reverting Install.daml:198 to = None still fails the test. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
salindne
marked this pull request as ready for review
September 3, 2026 18:52
Trimming the test changed the splice-wallet-test DAR, and splitwell-test takes it as a data-dependency, so both hashes move. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
Say what is surprising about the code rather than why the change is right. The reasoning is in the commit messages and the PR. Editing Install.daml moves the splice-wallet DAR hash, and splice-wallet-test and splitwell-test data-depend on it, so the lockfile follows. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
rename.sh no_illegal_daml_references bans "global" in Daml code. The comment this replaced already used the sanctioned term. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
Editing Install.daml moves the splice-wallet package hash. dars.lock and DarResources.scala both pin it, and only the first was regenerated, so every test that resolves a DAR through DarResources failed. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs ChainSafe/canton-extending-mainnet#39
Summary:
CO_BuyMemberTrafficgains an optional registration and forwards it toAmuletRules_BuyMemberTraffic, so the validator top-up path can buy traffic for a registered synchronizer. Daml half only, so canton-network#39 stays open; producers passNoneuntil the Scala half lands in its own PR.Verified: reverting the forward at
Install.daml:198toNonefails the new test.