Render every link on a catalog card, not just the first - #160
Open
dominicrume wants to merge 1 commit into
Open
Conversation
tools.json lets an entry declare several links, but the card template only ever emitted links[0], on the title. 19 of the 56 entries declare more than one, so a tool whose package, demo or spec lives behind link two is listed with no way to reach it. Adds a .card-links row after the description using the existing border and muted tokens, at the same size and radius as .badge-devfund. Cards with a single link render exactly as before, and a link with no label falls back to 'Link' rather than emitting an empty anchor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools.jsonlets an entry declare several links, but the catalog template only ever emitslinks[0], on the card title. Everything after it is dropped.19 of the 56 entries declare more than one link, so a tool whose package, demo or spec lives behind link two is listed on the hub with no way to reach it. Counting the rendered page today: 0 cards show more than one link, and 24 declared URLs never appear.
One file, 16 lines. A
.card-linksrow after the description, using the existing--borderand--mutedtokens at the same font size and pill radius as.badge-devfund, so it matches the cards rather than introducing a new style.Verified by regenerating the catalog from the current
tools.json:Cards with a single link render byte-identically to now, and a link with no
labelfalls back to "Link" rather than emitting an empty anchor.llms.txtgeneration is untouched.I noticed this after my own entry was merged in #156 — it declares five links and four of them were invisible — but the fix is the template, and it applies to eighteen other tools before it applies to mine.