fix(lib): log instead of silently swallowing errors in LogNonSigners - #564
Open
0xrlawrence wants to merge 1 commit into
Open
fix(lib): log instead of silently swallowing errors in LogNonSigners#5640xrlawrence wants to merge 1 commit into
0xrlawrence wants to merge 1 commit into
Conversation
LogNonSigners has no return values, so the two 'err = ErrInvalidSignerBitmap(...)' assignments followed by a bare return discarded the diagnosis entirely. A malformed signer bitmap caused non-signer logging to stop with no trace, which is exactly the moment an operator would want a log line. The early NewValidatorSet failure returned silently for the same reason. All three paths now log through the LoggerI the function already receives. staticcheck flagged the dead assignments as SA4006. Behaviour is otherwise unchanged: the function still returns early on each error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LogNonSignershas no return values, so these two assignments discarded the error entirely:A malformed signer bitmap caused non-signer logging to stop with no trace at all — exactly the moment an operator would want a log line. The early
NewValidatorSetfailure returned silently for the same reason.staticcheck flagged the dead assignments as SA4006.
Changes Made
LoggerIthe function already receives.err.Control flow is unchanged: the function still returns early on each error.
Testing
go build ./...go test ./lib/passeslib/consensus.go🤖 Generated with Claude Code