general-hooks/generic: drop main code#607
Open
bdrung wants to merge 1 commit into
Open
Conversation
bdrung
force-pushed
the
drop-main-from-generic
branch
from
af473dc to
e631b1f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 84.47% 84.47% -0.01%
==========================================
Files 106 106
Lines 21053 21051 -2
Branches 3223 3221 -2
==========================================
- Hits 17784 17782 -2
- Misses 2792 2793 +1
+ Partials 477 476 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mypy will complain if `ProblemReport` will get type hints:
```
data/general-hooks/generic.py:126: error: If x = b'abc' then f"{x}" or "{}".format(x) produces "b'abc'", not "abc". If this is desired behavior, use f"{x!r}" or "{!r}".format(x). Otherwise, decode the bytes [str-bytes-safe]
```
This code in the generic general hook is only there for testing. Drop
this code and test `add_info` directly.
bdrung
force-pushed
the
drop-main-from-generic
branch
from
e631b1f to
debe7c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy will complain if
ProblemReportwill get type hints:This code in the generic general hook is only there for testing. Drop this code and test
add_infodirectly.