feat: support subject tags in text notes and add NIP-14 support coverage#566
Open
a-khushal wants to merge 2 commits intocameri:mainfrom
Open
feat: support subject tags in text notes and add NIP-14 support coverage#566a-khushal wants to merge 2 commits intocameri:mainfrom
a-khushal wants to merge 2 commits intocameri:mainfrom
Conversation
🦋 Changeset detectedLatest commit: b9c833d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d79ce4b to
e802b3d
Compare
Collaborator
…ith units tests to validate parsing and repository behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds NIP-14 support so text note events can include a subject tag.
Description
this pr adds support for nip-14 subject tags in text note events (kind 1). it makes sure the tags are accepted, stored, and handled properly, and updates the relay to show support for nip14.
Related Issue
nostream#523
Motivation and Context
this change adds support for nip-14 subject tags in text note events (kind 1). without this, subject tags may not be handled or stored properly. it ensures the relay correctly supports nip-14.
How Has This Been Tested?
locally, ran i ran
npm run lintandnpm run build:check, and both passed.also ran unit tests covering schema validation for text note events with
["subject", "..."]and repository coverage.`Screenshots (if appropriate):
Types of changes
Checklist: