Skip to content

feat: support subject tags in text notes and add NIP-14 support coverage#566

Open
a-khushal wants to merge 2 commits intocameri:mainfrom
a-khushal:feat/nip14-subject
Open

feat: support subject tags in text notes and add NIP-14 support coverage#566
a-khushal wants to merge 2 commits intocameri:mainfrom
a-khushal:feat/nip14-subject

Conversation

@a-khushal
Copy link
Copy Markdown
Contributor

This PR adds NIP-14 support so text note events can include a subject tag.

Description

this pr adds support for nip-14 subject tags in text note events (kind 1). it makes sure the tags are accepted, stored, and handled properly, and updates the relay to show support for nip14.

Related Issue

nostream#523

Motivation and Context

this change adds support for nip-14 subject tags in text note events (kind 1). without this, subject tags may not be handled or stored properly. it ensures the relay correctly supports nip-14.

How Has This Been Tested?

locally, ran i ran npm run lint and npm run build:check, and both passed.
also ran unit tests covering schema validation for text note events with ["subject", "..."] and repository coverage.`

Screenshots (if appropriate):

image

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

🦋 Changeset detected

Latest commit: b9c833d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@a-khushal a-khushal force-pushed the feat/nip14-subject branch from d79ce4b to e802b3d Compare April 22, 2026 12:45
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 22, 2026

Coverage Status

coverage: 74.929%. remained the same — a-khushal:feat/nip14-subject into cameri:main

…ith units tests to validate parsing and repository behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants