Repository navigation
Avoid redundant MTP prefill work - #196
Merged
Merged
Conversation
Signed-off-by: VyasGuru <71374747+VyasGuru@users.noreply.github.com>
forward_hidden keeps its signature. Prefill never evaluates the per-chunk logits, so they are never computed, and runs lm_head once on the last prompt position.
Contributor
|
@VyasGuru thank you for this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Performance
on Apple M3, using four-token chunks and a 16K-vocabulary projection:
gains on full model behavour will of course be smaller, this benchmark only isolates the removed work.