Repository navigation
fix: oauth/revoke is not mirrored under /api/v3/ - #2692
Conversation
Confirmed live in prod: every Strava deauthorize call has been 404ing since the oauth/deauthorize -> oauth/revoke migration (#2689), because unlike oauth/token, Strava's oauth/revoke endpoint only exists at https://www.strava.com/oauth/revoke, not under /api/v3/. Strava's server was responding with a REST-style 404 ("Record Not Found", field: path) instead of an auth error, which is why it wasn't caught by the earlier unit tests (they mock axios entirely, so a wrong-but-well-formed URL string still "worked"). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-3.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f312b61) 2214 2037 92.01% Head commit (bc432f8) 2215 (+1) 2038 (+1) 92.01% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#2692) 2 2 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 participant
Contexte
Confirmé en prod : chaque appel de déconnexion Strava échoue avec un 404 depuis la migration
oauth/deauthorize→oauth/revoke(#2689) :```
"message":"Request failed with status code 404" ... url:"https://www.strava.com/api/v3/oauth/revoke"
"message":"Record Not Found","errors":[{"resource":"resource","field":"path","code":"invalid"}]
```
Contrairement à
oauth/token, l'endpointoauth/revokede Strava n'existe qu'àhttps://www.strava.com/oauth/revoke, pas sous/api/v3/. Le serveur Strava répondait par un 404 de type REST ("Record Not Found") plutôt qu'une erreur d'auth, ce qui explique que les tests unitaires existants (qui mockent axios entièrement) ne l'aient pas attrapé — une URL syntaxiquement correcte mais fausse "passait" quand même le mock.Test plan
tsc --noEmitet lint propres