feat(rumqttc): Support fallible request modifiers for websocket connections - #1030
Open
michelhe wants to merge 1 commit into
Open
feat(rumqttc): Support fallible request modifiers for websocket connections#1030michelhe wants to merge 1 commit into
michelhe wants to merge 1 commit into
Conversation
…ctions The set_request_modifier API now accepts closures that return either `http::Request<()>` (infallible) or `Result<http::Request<()>, E>` (fallible). This change is backwards compatible - existing code returning requests directly continues to work unchanged. New code can now use the ? operator and propagate errors instead of using unwrap(). Modifier errors are surfaced as ConnectionError::RequestModifier, allowing proper error handling during connection establishment. Changes: - Add IntoModifierResult trait for accepting both return types - Add ConnectionError::RequestModifier variant for error propagation - Extract shared types into request_modifier module (used by v4 and v5) - Add documentation with usage examples - Add unit and integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set_request_modifier API now accepts closures that return either
http::Request<()>(infallible) orResult<http::Request<()>, E>(fallible).This change is backwards compatible - existing code returning requests directly continues to work unchanged. New code can now use the ? operator and propagate errors instead of using unwrap().
Modifier errors are surfaced as ConnectionError::RequestModifier, allowing proper error handling during connection establishment.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.