Repository navigation
Include C++ sources in the shared formatter - #385
Merged
Merged
Conversation
EdSchouten
reviewed
Oct 5, 2026
finn-ball
commented
Oct 5, 2026
| # Protobuf | ||
| find . -name '*.proto' -exec "$clang_format" -i {} + | ||
| # C++ and Protobuf | ||
| find . \( -name '*.proto' -o -name '*.cc' -o -name '*.cpp' -o -name '*.cxx' \ |
Contributor
Author
There was a problem hiding this comment.
Would you like this to remain as a find or would git-ls-files be more appropriate?
finn-ball
force-pushed
the
fix/cpp-formatting
branch
from
October 5, 2026 11:31
e217daf to
7fe3c20
Compare
Member
|
Find is fine. That way you don't need to "git add" before running the reformatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the existing clang-format invocation to cover C++ sources and headers alongside Protobuf files, so downstream repositories can use the shared formatting check for C++.