Repository navigation
LTS-5442: verify the CLI signature before running it, pin Semgrep - #2
Merged
Merged
Conversation
- LTS-5540: the README had users run the downloaded CLI with no integrity check. The macOS build is Developer ID signed (Browserstack Inc, YQ5FZQ855D) and the Windows build is Authenticode signed, so add a verification step for both before running it. Also note the download is a zip. Linux builds are unsigned and no checksum is published, so Linux stays open on the story as a CLI release follow-up. - LTS-5535: pull returntocorp/semgrep:1.166.0 by digest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
MohitSinghBS
approved these changes
Oct 28, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two findings from the LTS-5442 security AI review of this sample.
Changes
codesignon macOS (must showTeamIdentifier=YQ5FZQ855D, Browserstack Inc) andGet-AuthenticodeSignatureon Windows. The README also now says the download is a zip that has to be extracted; it previously said to place "the binary".returntocorp/semgrep:1.166.0@sha256:c180f0c93a17b420c0af5006214a29d3c747c5459c732b740191adf657dd0068.What the downloads carry today (checked 2026-10-27, CLI 1.62.0)
Developer ID Application: Browserstack Inc (YQ5FZQ855D), chained to Apple Root CAVerification
TeamIdentifier=YQ5FZQ855D.codesign --verify..exedoes carry an Authenticode certificate table naming BrowserStack.Not fixed here
Linux users still have nothing to verify against. That needs a published checksum (or a signature) from the CLI release process / binary endpoint, so it stays open on LTS-5540 as a follow-up rather than something this sample can fix.
No load-testing-backend change: this sample isn't bundled in
sample/.Part of LTS-5442.
🤖 Generated with Claude Code