fix: safely disable mem0 for non-OpenAI models#739
Open
RainCongeals wants to merge 2 commits into
Open
Conversation
- Use getattr to safely check for model_name attribute, resolving Pylance type warnings. - Automatically disable vector memory for non-OpenAI LLMs to prevent API key errors. - Add assertion to ensure main_llm is initialized before agent creation.
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Safely disables
mem0vector memory for non-OpenAI models and ensures the LLM is initialized before creating the agent. Prevents OpenAI API key errors and resolves type-check warnings.llm_provider_namewhen available; disable vector memory and log a clear warning.Written for commit 8460bd2. Summary will update on new commits.