This repository was archived by the owner on May 26, 2022. It is now read-only.
Add setCellVerticalAlignment() & allow setShouldWrapText() to be explicitly set as false#869
Open
jonnott wants to merge 1 commit into
Open
Add setCellVerticalAlignment() & allow setShouldWrapText() to be explicitly set as false#869jonnott wants to merge 1 commit into
jonnott wants to merge 1 commit into
Conversation
|
|
Author
jonnott
force-pushed
the
vertical-alignment-wraptext
branch
from
f8d8296 to
a0dceef
Compare
adrilo
reviewed
Feb 12, 2022
…icitly set as false - add Common\Entity\Style\CellVerticalAlignment - duplicate get/set/hasSet/shouldApply methods for CellAlignment in Common\Entity\Style\Style for CellVerticalAlignment instead, plus corresponding properties - add setCellVerticalAlignment method to Common\Creator\Style\StyleBuilder - add vertical alignment to StyleMerger:: mergeCellProperties() - adjust wrapText logic in mergeCellProperties() to fix issue box#829 - apply vertical cell styling for both XLSX and ODS, via corresponding StyleManager classes - transform vertical alignment ‘center’ to ‘middle’ for ODS - fix logic around wrapText such that the choice whether to include wrapping styles depends on hasSetWrapText() being true, and then use shouldWrapText() thereafter to either set wrapping or no wrapping (for XLSX, wrapText=“1” or wrapText=“0”, for ODS, wrap-option=wrap or wrap-option=no-wrap). previously there was no way to set wrapping to be OFF, only to set it to be ON. - add new tests to ensure shouldWrapText(false) results in the correct negated wrapText (XLSX) / wrap-option (ODS) styles - add new tests to StyleBuilderTest for vertical alignment - add vertical alignment to documentation.md
jonnott
force-pushed
the
vertical-alignment-wraptext
branch
from
a0dceef to
887d6ef
Compare
Author
Author
|
@adrilo Do you see any outstanding issues with this still preventing a merge? |
Author
|
Anyone know if there's any likelihood that this will get merged any time soon? Or do I need to submit this PR to openspout/openspout and look to use that in my project instead? |
|
Merged in openspout/openspout#63 tnx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues:
#829
#737