Skip to content

Added SparklinesInteractiveLayer - #119

Open
vegetableman wants to merge 1 commit into
borisyankov:masterfrom
vegetableman:master
Open

Added SparklinesInteractiveLayer#119
vegetableman wants to merge 1 commit into
borisyankov:masterfrom
vegetableman:master

Conversation

@vegetableman

Copy link
Copy Markdown

Made it a little interactive

interactive

@arslanhashmi

arslanhashmi commented Jul 11, 2020

Copy link
Copy Markdown

@borisyankov are we going to have this similar interactive layer at some point?

@qcho

qcho commented Sep 3, 2021

Copy link
Copy Markdown

Great PR! Just what I was looking for.

Question. Did you need an updated version of react and react-dom for this?

If not, it's probably making the scope for this PR bigger than it should

@vegetableman

vegetableman commented Sep 5, 2021

Copy link
Copy Markdown
Author

It's been 3 years... time sure passes.

Anyways, @qcho had to check my code again. On the issue, I updated react because I was using React.Fragment which is not supported in react 15.

Have updated the PR now and I have removed fragment, reverted the versions back to old one and now am using the svg g tag which works equally well.

Cheers!

tobilg pushed a commit to tobilg/react-sparklines-next that referenced this pull request Nov 10, 2025
, borisyankov#122, borisyankov#130

- PR borisyankov#46: Add gap support for null/NaN/Infinity values in data
  - Modified dataToPoints to mark invalid values with valid flag
  - Created segmentPoints utility to split data into valid segments
  - Updated SparklinesLine, SparklinesCurve, and SparklinesBars to handle gaps
  - Added comprehensive tests for gap handling

- PR borisyankov#113: Add fillInvert style option to SparklinesLine
  - Allows inverting the fill direction for line charts

- PR borisyankov#119: Add SparklinesInteractiveLayer component
  - New component for interactive hover/click with visual feedback
  - Shows active point with circle and vertical line

- PR borisyankov#122: Remove empty onMouseMove handler from SparklinesLine
  - Made tooltips conditional on onMouseMove presence

- PR borisyankov#130: Update README with improved code examples
  - Use proper JSX syntax highlighting
  - Wrap examples in function components

All tests passing (25 tests across 5 test files)
tobilg pushed a commit to tobilg/react-sparklines-next that referenced this pull request Nov 10, 2025
- Document gap support for null/NaN/Infinity values
- Add section for fillInvert style option (PR borisyankov#113)
- Add section for SparklinesInteractiveLayer component (PR borisyankov#119)
- Standardize all code examples with proper JSX syntax and function wrappers
- Improve formatting with bold property names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants