test: Failing tier-0 validate — required-checks should be red#62
Open
cgwalters wants to merge 1 commit into
Open
test: Failing tier-0 validate — required-checks should be red#62cgwalters wants to merge 1 commit into
cgwalters wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new text file, test-results/validate-fail.txt, which is intended to trigger a CI validation failure. A review comment suggests adding a trailing newline to the file to adhere to POSIX standards and ensure compatibility with command-line tools.
| @@ -0,0 +1 @@ | |||
| This PR has ci/fail-validate so the tier-0 validate job fails. required-checks should go RED and block merge queue entry. No newline at end of file | |||
Contributor
There was a problem hiding this comment.
The file is missing a trailing newline. It is a best practice to end all text files with a newline character to ensure compatibility with POSIX standards and various command-line tools.
This PR has ci/fail-validate so the tier-0 validate job fails. required-checks should go RED and block merge queue entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has ci/fail-validate so the validate job (tier-0) will fail. This exercises the path where required-checks correctly blocks the PR. The PR should NOT be able to enter the merge queue.