Export BuildFileIndex; decouple crawl from progress bar#66
Open
SUSTAPLE117 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b0d4ad0 to
65cebc8
Compare
Contributor
Author
|
Heads-up: the boostfree-endpoint consumer has pivoted to owning its scanning engine (its own group-scoped walker populating a Not asking to drop it — it's still useful for bagel's own CLI and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract collector.buildFileIndex into an exported free function collector.BuildFileIndex
Progress is abstracted behind a new pkg/progress.Reporter interface (Start/Update/Done) with a NoOp default, replacing the hardcoded progressbar. BuildFileIndex depends only on the interface