Skip to content

Export BuildFileIndex; decouple crawl from progress bar#66

Open
SUSTAPLE117 wants to merge 1 commit into
maint/export-dedupfrom
maint/export-buildindex
Open

Export BuildFileIndex; decouple crawl from progress bar#66
SUSTAPLE117 wants to merge 1 commit into
maint/export-dedupfrom
maint/export-buildindex

Conversation

@SUSTAPLE117

Copy link
Copy Markdown
Contributor

Extract collector.buildFileIndex into an exported free function collector.BuildFileIndex

Progress is abstracted behind a new pkg/progress.Reporter interface (Start/Update/Done) with a NoOp default, replacing the hardcoded progressbar. BuildFileIndex depends only on the interface

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@SUSTAPLE117 SUSTAPLE117 force-pushed the maint/export-buildindex branch from b0d4ad0 to 65cebc8 Compare July 13, 2026 14:57
@SUSTAPLE117

Copy link
Copy Markdown
Contributor Author

Heads-up: the boostfree-endpoint consumer has pivoted to owning its scanning engine (its own group-scoped walker populating a fileindex.FileIndex), so it no longer calls collector.BuildFileIndex. This export is now unused by the endpoint.

Not asking to drop it — it's still useful for bagel's own CLI and the progress.Reporter abstraction is nice to keep. Just flagging that the endpoint dependency that motivated it is gone, so this PR can be evaluated purely on bagel-CLI merits (or closed if the CLI doesn't need it). bagel #64 and #65 remain consumed by the endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant