Repository navigation
build: replace in-repo optional nil and encapsulation linters with tsk - #28
Conversation
tsk bundles the optional nil check alongside other linters, so the repository no longer needs to build and maintain its own copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tsk already runs the same encapsulation check, so running both duplicates work and leaves an extra tool to keep up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alecthomas
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f71628621c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bit only reruns a task when its inputs change, so editing the tsk config or upgrading tsk alone would reuse a stale lint result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
tsk bundles the optional nil and encapsulation checks with other Go linters, so the repository no longer needs to maintain its own optional nil linter or install the separate encapsulation linter.
A single
lint-tskbuild target now runs every enabled tsk linter. It replaces thelint-optionalandlint-encapsulationtargets, theoptionalnilcommand, and theencapsulation-linterpackage. The one intentional nil now uses tsk's//nolint:optionalnilcomment, and the agent guidelines describe how to suppress any tsk finding.🤖 Generated with Claude Code