Skip to content

chore: bump Goose backend for GPT 6.1 Sol compaction - #378

Merged
atishpatel merged 1 commit into
mainfrom
atish/goose-compaction-pin
Oct 5, 2026
Merged

atishpatel merged 1 commit into
mainfrom
atish/goose-compaction-pin

Conversation

@atishpatel

@atishpatel atishpatel commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Category: fix

User Impact: Users of GPT 6.1 Sol receive the upstream fix for compaction requests that send an unsupported reasoning effort.

Problem: Berd's current Goose pin predates the fix for hyphenated GPT 6.1 Sol model aliases. Compaction with reasoning off can send none, which the model rejects.

Solution: Bump the Goose backend from 4dea9b483efbd2541d43500b8ed3c044c65e6d2f to 7debb275d36559ee4e81799362e7f638275dfed3, the merge commit of aaif-goose/goose#12689. The fix maps reasoning off to the supported low effort for these aliases. Model defaults and the vendored SDK stay unchanged.

This pin includes 32 upstream commits, not only the compaction fix. Review the upstream comparison for the full scope. No changes to the architectural laws in LAWS/AGENTS.md or LAWS/CHAT.md.

File changes

goose-backend.lock.json
Update both ref and commit to the merged Goose SHA. Keep the repository, package, and binary unchanged, following #363.

Related issue

Refs aaif-goose/goose#12687. No matching open Berd issue or duplicate pin-bump PR found.

Testing

  • Ran ./scripts/update-goose-backend-lock.sh 7debb275d36559ee4e81799362e7f638275dfed3 to resolve and record the upstream SHA.
  • Verified that ref and commit equal the requested SHA, with every other lockfile field unchanged.
  • Local just ci stopped at two 15-second release-test timeouts. just release-scripts-test build passed on an isolated retry; all earlier gate steps passed.
  • No packaged-app or live compaction test performed.

Generated with Codex

@atishpatel
atishpatel marked this pull request as ready for review October 5, 2026 21:21
@atishpatel
atishpatel requested a review from a team October 5, 2026 21:21

@morgmart morgmart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review

APPROVE. The exact prepared three-dot comparison changes only the Goose backend pin, with both lock fields updated to the same revision. No publishable findings or escalations remain. The supplied evidence reports successful check runs at the exact head SHA; required checks still govern merge readiness.

Deterministic publication result: 0 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.

Pending checks: 1 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.

@atishpatel
atishpatel merged commit f23b350 into main Oct 5, 2026
11 of 12 checks passed
@atishpatel
atishpatel deleted the atish/goose-compaction-pin branch October 5, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants