Repository navigation
chore: bump Goose backend for GPT 6.1 Sol compaction - #378
Merged
Merged
Conversation
atishpatel
marked this pull request as ready for review
October 5, 2026 21:21
kalvinnchau
approved these changes
Oct 5, 2026
morgmart
approved these changes
Oct 5, 2026
morgmart
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Automated code review
APPROVE. The exact prepared three-dot comparison changes only the Goose backend pin, with both lock fields updated to the same revision. No publishable findings or escalations remain. The supplied evidence reports successful check runs at the exact head SHA; required checks still govern merge readiness.
Deterministic publication result: 0 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
Pending checks: 1 check(s) are not complete.
This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Category: fix
User Impact: Users of GPT 6.1 Sol receive the upstream fix for compaction requests that send an unsupported reasoning effort.
Problem: Berd's current Goose pin predates the fix for hyphenated GPT 6.1 Sol model aliases. Compaction with reasoning off can send
none, which the model rejects.Solution: Bump the Goose backend from
4dea9b483efbd2541d43500b8ed3c044c65e6d2fto7debb275d36559ee4e81799362e7f638275dfed3, the merge commit of aaif-goose/goose#12689. The fix maps reasoning off to the supportedloweffort for these aliases. Model defaults and the vendored SDK stay unchanged.This pin includes 32 upstream commits, not only the compaction fix. Review the upstream comparison for the full scope. No changes to the architectural laws in
LAWS/AGENTS.mdorLAWS/CHAT.md.File changes
goose-backend.lock.json
Update both
refandcommitto the merged Goose SHA. Keep the repository, package, and binary unchanged, following #363.Related issue
Refs aaif-goose/goose#12687. No matching open Berd issue or duplicate pin-bump PR found.
Testing
./scripts/update-goose-backend-lock.sh 7debb275d36559ee4e81799362e7f638275dfed3to resolve and record the upstream SHA.refandcommitequal the requested SHA, with every other lockfile field unchanged.just cistopped at two 15-second release-test timeouts.just release-scripts-test buildpassed on an isolated retry; all earlier gate steps passed.Generated with Codex