[PM-37727] Fix exceptions when serialzing blob-encrypted ciphers#7667
Open
nikwithak wants to merge 1 commit into
Open
[PM-37727] Fix exceptions when serialzing blob-encrypted ciphers#7667nikwithak wants to merge 1 commit into
nikwithak wants to merge 1 commit into
Conversation
nikwithak
changed the title
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7667 +/- ##
==========================================
+ Coverage 59.98% 64.49% +4.51%
==========================================
Files 2133 2133
Lines 93731 93741 +10
Branches 8311 8314 +3
==========================================
+ Hits 56220 60458 +4238
+ Misses 35531 31208 -4323
- Partials 1980 2075 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-37727
📔 Objective
When saving a blob-encrypted cipher from the client, the Server throws errors because it is expecting the JSON data for parsing. This adds a function call to see if a cipher is blob encrypted, and skip the ciphertype extractions if so.