Skip to content

[PM-35656] Add Events for New Item Types#7642

Merged
nick-livefront merged 2 commits into
mainfrom
vault/pm-35656/new-item-type-events
May 20, 2026
Merged

[PM-35656] Add Events for New Item Types#7642
nick-livefront merged 2 commits into
mainfrom
vault/pm-35656/new-item-type-events

Conversation

@nick-livefront
Copy link
Copy Markdown
Contributor

@nick-livefront nick-livefront commented May 15, 2026

🎟️ Tracking

PM-35656

📔 Objective

After the initial changes were in for new item types, additional fields were made hidden and/or copyable. To match existing patterns, these scenarios need events for organizations. Adding the missing fields here:

  • Bank Account
    • IBAN
    • SWIFT
  • Passport
    • NationalIdentificationNumber

Initial addition PRs:

📸 Screenshots

N/A

@nick-livefront nick-livefront requested a review from a team as a code owner May 15, 2026 16:03
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.96%. Comparing base (b97744d) to head (3186b57).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7642      +/-   ##
==========================================
+ Coverage   59.84%   59.96%   +0.11%     
==========================================
  Files        2121     2133      +12     
  Lines       93460    93703     +243     
  Branches     8291     8306      +15     
==========================================
+ Hits        55932    56186     +254     
+ Misses      35547    35537      -10     
+ Partials     1981     1980       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nick-livefront nick-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a small, focused change that adds six new EventType enum values (Cipher_ClientCopiedSwiftCode, Cipher_ClientToggledSwiftCodeVisible, Cipher_ClientCopiedIban, Cipher_ClientToggledIbanVisible, Cipher_ClientCopiedNationalIdentificationNumber, Cipher_ClientToggledNationalIdentificationNumberVisible) and registers them in CollectController.Post. The change also registers the previously-declared Cipher_ClientCopiedLicenseNumber, Cipher_ClientToggledLicenseNumberVisible, Cipher_ClientCopiedPassportNumber, and Cipher_ClientToggledPassportNumberVisible cases in the controller switch, which had been added to the enum in PR #7512 but not wired through. New enum values are sequential (1127-1132), no existing values are renumbered, and the switch fall-through pattern matches the established cipher-event handling. Events only carry cipher ID + event type, preserving the zero-knowledge invariant.

No findings.

@sonarqubecloud
Copy link
Copy Markdown

@nick-livefront nick-livefront merged commit 497e785 into main May 20, 2026
44 checks passed
@nick-livefront nick-livefront deleted the vault/pm-35656/new-item-type-events branch May 20, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants