Refractor runtime persister to error out when not persisted - #320
Open
emma31-dev wants to merge 4 commits into
Open
Refractor runtime persister to error out when not persisted#320emma31-dev wants to merge 4 commits into
emma31-dev wants to merge 4 commits into
Conversation
Return an error when wallet persistence fails instead of silently succeeding when no changes were written.
emma31-dev
force-pushed
the
refractor/runtime-persister
branch
from
September 7, 2026 14:04
b9dfd02 to
8cc7f45
Compare
Signed-off-by: emma31-dev <emmanuelfidel07@gmail.com>
emma31-dev
force-pushed
the
refractor/runtime-persister
branch
from
September 7, 2026 14:10
682a107 to
49a2afd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
persist()method ofRuntimeWalletreturnsok(())wether or not the wallet was persisted or not. This is bad practice. My changes Return an error when wallet persistence fails instead of silently succeeding when no changes were written.All Submissions:
cargo fmtandcargo clippybefore committingThank you.