feat(core): make locale required on client.fetch()#2982
Draft
feat(core): make locale required on client.fetch()#2982
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 45e611b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
jorgemoya
changed the title
jorgemoya
changed the title
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
212cd68 to
e96f4d8
Compare
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
e96f4d8 to
d921023
Compare
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
d921023 to
e292d4e
Compare
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
e292d4e to
36bd51c
Compare
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
36bd51c to
8a54949
Compare
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
8a54949 to
b7bbcd7
Compare
…equest Add optional locale parameter to client.fetch() for use in cached contexts. Wrap headers() call in beforeRequest with try/catch so it gracefully degrades inside unstable_cache. No changes to getChannelId or beforeRequest callback signatures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wrap home page, header, footer, SEO canonical, reCAPTCHA, and root layout metadata queries in unstable_cache for guest visitors. Authenticated requests continue to bypass the cache with no-store. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wrap product details, pricing, inventory, variant inventory, related products, inventory settings, and reviews queries in unstable_cache for guest visitors. Authenticated requests bypass the cache. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…_cache Wrap brand, category, search, compare, and quick search queries in unstable_cache for guest visitors. Faceted search uses 300s revalidation; others use the default interval. Authenticated requests bypass the cache. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wrap blog, web pages, gift certificates, public wishlist, change password, and shipping countries queries in unstable_cache for guest visitors. This completes the guest query caching migration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Make the locale parameter required (not optional) on client.fetch() to ensure correct channel resolution and Accept-Language header in all contexts, including inside unstable_cache where getLocale() is unavailable. All call sites now explicitly pass locale. Build-time contexts (next.config.ts, robots.txt, favicon.ico) and proxies pass an empty string as locale since no request context is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jorgemoya
force-pushed
the
LTRAC-226/locale-required
branch
from
b7bbcd7 to
45e611b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: LTRAC-226
What/Why?
Makes
localea required parameter onclient.fetch()instead of optional. This ensures every fetch call explicitly provides locale for correct channel resolution andAccept-Languageheader, preventing silent fallback failures insideunstable_cachewheregetLocale()is unavailable.67 files updated across server actions, page-data functions, auth, cart utilities, analytics, components, and route handlers. Build-time contexts (
next.config.ts,robots.txt,favicon.ico) and proxies pass''as locale since no request context is available there.Final PR in the series splitting #2910. Depends on #2981.
Rollout/Rollback
Breaking change for
@bigcommerce/catalyst-clientconsumers —localeis now required onclient.fetch(). Rollback is a simple revert.Testing
tsc --noEmitpasses with 0 errorspnpm lintpasses🤖 Generated with Claude Code