feat: close Muse ACP sessions cleanly - #4
Draft
obviyus wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The adapter does not advertise or implement ACP
session/close. ACPX and other clients cannot ask it to cancel active work and release adapter session resources through the protocol.Fix
sessionCapabilities.closeand registersession/close.session/listandsession/loadrecovery continue to work.Lifecycle proof
session/listafter close.Verification
npm run checknpm run buildnpm run test:run— 116 passed, 2 live-provider tests skippedDependencies
This draft is stacked on #2 and #3. Merge those first; GitHub will then reduce this PR to the close lifecycle change.