feat(altsvc): wire parse_and_cache into response path#846
Merged
Conversation
hackney_conn invokes hackney_altsvc:parse_and_cache after every response (http1 sync+async, h2, h3) so server Alt-Svc headers actually populate the cache. Also: clear directive now invalidates the entry, multiple Alt-Svc headers are merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hackney_altsvc:parse_and_cache/3 existed but no call site invoked it, so server-advertised h3 endpoints were silently dropped. hackney_conn now hooks it from every response path (http1 sync+async, h2, h3). Also fixes two parser bugs the wiring exposed:
Alt-Svc: clearnow invalidates the cached entry, multiple Alt-Svc headers are merged per RFC 7230 §3.2.2.