test(pypi): check index url precedence in various combinations#3698
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Apr 12, 2026
Merged
Conversation
This just adds extra tests to verify behaviour end-to-end to better reason in case of any bug reports during the RC phase. Followup to bazel-contrib#3691
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the experimental_extra_index_urls parameter to the pip_parse extension and adds comprehensive unit tests in hub_builder_tests.bzl to verify the precedence of index URLs. The tests confirm that URLs defined within requirements.txt correctly override those provided via attributes. I have no feedback to provide as there were no review comments.
rickeylev
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds extra tests to verify behaviour end-to-end to better
reason in case of any bug reports during the RC phase.
Followup to #3691