Repository navigation
Conversation
On Windows, the test command runs through two shell layers:
GitHub Actions (PowerShell)
-> npm cit
-> npm test (cmd.exe)
-> bats ${CI+-t} test
cmd.exe does not understand the POSIX ${CI+-t} expansion. It passes the expression to Bats as an argument, which Bats interprets as a test path and fails before running any tests.
The expansion was added in 2019 to select TAP output in CI, but Bats has done that automatically when CI is set since 2014. Remove the redundant expansion so npm test works across platforms without changing CI output.
Author
|
Also related to PR 1258 fixing BATS_LIB_PATH on Windows in bats-core Without it, this bats-assert/test/test_helper.bash Line 2 in 697471b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the test command runs through two shell layers:
GitHub Actions (PowerShell)
-> npm cit
-> npm test (cmd.exe)
-> bats ${CI+-t} test
cmd.exe does not understand the POSIX ${CI+-t} expansion. It passes the expression to Bats as an argument, which Bats interprets as a test path and fails before running any tests.
The expansion was added in 2019 to select TAP output in CI, but Bats has done that automatically when CI is set since 2014. Remove the redundant expansion so npm test works across platforms without changing CI output.