fix(docs): replace broken appLogoUrl example (base.org/logo.png returns 404)#1317
Open
ygd58 wants to merge 1 commit intobase:masterfrom
Open
fix(docs): replace broken appLogoUrl example (base.org/logo.png returns 404)#1317ygd58 wants to merge 1 commit intobase:masterfrom
ygd58 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
ygd58
force-pushed
the
fix/broken-appLogoUrl-examples
branch
from
ed68781 to
da4b016
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was going through the SDK code examples and noticed base.org/logo.png is used as the appLogoUrl in multiple places. Tested it and it returns 404. Anyone copying these examples will see a broken image in their app popup. Searched across the docs and found it in 6 files. Replaced with the Base GitHub avatar URL which returns 200. Affected files are paymasters.mdx, spend-permissions.mdx, sub accounts.mdx, batch-transactions.mdx, web.mdx and web-react.mdx.