Skip to content

Non-linear model defaults#900

Open
dominikbach wants to merge 11 commits into
developfrom
SCRopt_implementation
Open

Non-linear model defaults#900
dominikbach wants to merge 11 commits into
developfrom
SCRopt_implementation

Conversation

@dominikbach

@dominikbach dominikbach commented May 13, 2026

Copy link
Copy Markdown
Contributor

Fixes # .

Changed non linear model default in line with de Vries et al 2026) preprint.

Changes proposed in this pull request:

  • change default filter to unidirectional
  • change default flexible response dispersion to constrained, as simplest option for downstream analysis
  • integrate constrained and the hidden upper_constrained option

Please test with tutorial data.

@dominikbach dominikbach changed the title bugfixes Non-linear model defaults May 13, 2026
@dominikbach
dominikbach requested review from 4gwe and gjheij May 13, 2026 21:12
@4gwe 4gwe self-assigned this May 18, 2026
4gwe added 2 commits May 19, 2026 10:17

@gjheij gjheij left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dominikbach

Copy link
Copy Markdown
Contributor Author

aSCR offset was interchangeably taken from two different sources (pspm_init and pspm_options) which had different default values. Now removed from pspm_init and only set in DCM options. Help text adjusted as well.

@dominikbach

Copy link
Copy Markdown
Contributor Author

Current status:

f_SCR requires sigma_offset, which is currently passed via settings in line 54, and this setting field was removed. We need to create a different way of passing it. The easiest solution might be a field settings.temp  which is set in pspm_inv  (and removed at the end of the script) and read in f_SCR.

@dominikbach dominikbach added the Completed & Waiting for Review Completed and waiting for review label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Completed & Waiting for Review Completed and waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants