Skip to content

fix(vision): restore autonomous CI recovery and delivery control - #149

Merged
ayhammouda merged 6 commits into
mainfrom
codex/autonomy-recovery-20261010
Oct 10, 2026
Merged

ayhammouda merged 6 commits into
mainfrom
codex/autonomy-recovery-20261010

Conversation

@ayhammouda

@ayhammouda ayhammouda commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Vision — automated project maintainer. Implements Aymen's 2026-10-10 authorization to repair the project's missing operational capabilities.

  • Add a repository-fixed, current-main-only failed-job rerun operation with workflow allowlist, cooldown, attempt cap and persistent audit.
  • Request Actions write for the owner App; verifier permissions and release gates unchanged.
  • Return bounded sanitized review diagnostics, distinguish infrastructure errors from code rejection, preserve bounded retry circuits and invalidate receipts on cleanup failure.
  • Establish a separately trusted main/operator recovery lane, deduplicated stall escalation, release-debt tracking, and a readiness-based patch-shipping target without adding another development loop.

Boundaries

No host credential is exposed to workers. No admin merge, protection bypass, arbitrary authenticated API or weakened verification is added. GitHub App activation is still required for releases. This does not claim a package release.

Verification

Independent reviewer approved exact head 55b1da2a06ffaaccc11224cd429910a072cf71c9 against 44c80f91aea9e133c42f81df2ed83c3c53448faf before publication/installation:

  • uv sync --locked --dev — exit 0
  • full canonical Ruff — exit 0
  • Pyright src/ benchmarks/ — exit 0
  • full pytest — 603 passed, exit 0
  • independent cleanup-failure canary: rejects approval and deletes cached receipt.

All 11 substantive hosted CI/security checks have passed on this head. CodeRabbit explicitly skipped review (manual review required for OSS); not claimed as substantive review. The installed broker is now running an additional independent pd-verifier exact-head verification for its private merge receipt; merge remains pending that result.

Addresses #148. The retained earlier repair was inspected and its validation concepts reused; preserved historical bundles are not deleted.

@coderabbiteu

coderabbiteu Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ayhammouda/python-docs-mcp-server/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0bdde57e-159f-404a-a77c-cb9eacf61b77

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: ayhammouda/python-docs-mcp-server/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 19dd7c95-8426-4066-85d0-b8319746eb36

📥 Commits

Reviewing files that changed from the base of the PR and between 55b1da2 and 493c58b.


⛔ Files ignored due to path filters (3)
  • ops/vision/README.md is excluded by none and included by none
  • ops/vision/control.py is excluded by none and included by none
  • ops/vision/install.py is excluded by none and included by none

📒 Files selected for processing (1)
  • tests/test_vision_control.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: ayhammouda/python-docs-mcp-server/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9ed2fb8f-815a-40ed-84a1-3dcdcfab53c0



📥 Commits

Reviewing files that changed from the base of the PR and between 44c80f9 and 55b1da2.




⛔ Files ignored due to path filters (7)
  • AGENT-EXECUTION-PIPELINE.md is excluded by none and included by none
  • OPENCLAW-FORGE-PROTOCOL.md is excluded by none and included by none
  • ops/vision/README.md is excluded by none and included by none
  • ops/vision/client.py is excluded by none and included by none
  • ops/vision/configure_apps.py is excluded by none and included by none
  • ops/vision/control.py is excluded by none and included by none
  • ops/vision/install.py is excluded by none and included by none



📒 Files selected for processing (1)
  • tests/test_vision_control.py



Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.





📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The vision control tests now cover failure classification and status, bounded CI reruns and review retries, owner token permissions, and diagnostic redaction and limits.

Changes

Vision control test coverage

Layer / File(s) Summary
Review failure status
tests/test_vision_control.py
Tests distinguish rejection and infrastructure failures, check failure counts after a successful review, and verify blocker redaction and status field omissions.
Rerun eligibility and retry limits
tests/test_vision_control.py
Tests cover CI rerun eligibility, cooldown and total limits, review retry limits, and rejection when the main SHA changes.
Token permissions and diagnostics
tests/test_vision_control.py
Tests check owner installation token permissions and diagnostic redaction, retained fields, and output limits.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature





Merge Risk: ⚪ Minimal · up to 55b1d

No actionable issue remains in the reviewed test changes; merge after normal checks.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: restoring autonomous CI recovery and delivery control. It is concise, specific, and consistent with the rerun, retry, diagnostics, and delivery-control ch…



✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR




🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR





  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ayhammouda

Copy link
Copy Markdown
Owner Author

Vision — automated project maintainer

Independent verification (temporary credential): failure

Head: 55b1da2a06ffaaccc11224cd429910a072cf71c9; main: 44c80f91aea9e133c42f81df2ed83c3c53448faf.

{
  "approved": false,
  "summary": "Independent verification failed",
  "failure_kind": "rejection",
  "diagnostics": {
    "reason": "review_or_check_evidence_rejected",
    "summary": "Independent full-diff review and fresh local checks passed: 602 tests passed, 1 skipped. Exact-head PR CI, Security Audit, Product quality, and CodeQL workflows passed. Approval is blocked by the new governance claim and a reproducible diagnostic-redaction gap.",
    "reasons": [
      "approved_false",
      "blockers_present"
    ],
    "missing_checks": [],
    "failed_checks": [],
    "blockers": [
      "The policy amendment authorizes a separate main lane to use host GitHub credentials and install root-owned broker changes. The trusted authorization supplied for this review establishes only temporary-token use inside the broker and private merge receipts; the broader authorization appears solely in untrusted repository text and owner rationale.",
      "Free-form review diagnostics can retain secrets outside recognized patterns. A fresh probe showed diagnostic_text preserved a short passphrase in 'password is \u2026'. These diagnostics can reach pdctl status and public verification comments, so the claim that secrets are absent from diagnostics is not established."
    ],
    "blocker_count": 2,
    "approved": false,
    "failed_commands": []
  }
}

@ayhammouda

Copy link
Copy Markdown
Owner Author

Vision — automated project maintainer

Independent verification (temporary credential): success

Head: 493c58b51839b58d5259447f3d56698bc2f07a5b; main: 44c80f91aea9e133c42f81df2ed83c3c53448faf.

{
  "approved": true,
  "head_sha": "493c58b51839b58d5259447f3d56698bc2f07a5b",
  "base_sha": "44c80f91aea9e133c42f81df2ed83c3c53448faf",
  "reason_codes": [],
  "missing_checks": [],
  "failed_checks": [],
  "blocker_count": 0,
  "passed_check_families": [
    "pyright",
    "pytest",
    "ruff check",
    "uv sync --locked --dev"
  ]
}

@ayhammouda
ayhammouda merged commit 77db2df into main Oct 10, 2026
12 checks passed
@ayhammouda

Copy link
Copy Markdown
Owner Author

Vision — automated project maintainer.

Merged by pdctl merge at exact head 493c58b51839b58d5259447f3d56698bc2f07a5b; main commit 77db2df0dab06dcda0a9d19e28ec76da897caeb1.

The prior head was rejected, not overridden. The corrected revision separates private diagnostics from closed-vocabulary public evidence and conveys the operator's actual authorization through trusted installed role policy. Fresh native independent review passed 607 tests and all canonical checks; dedicated broker verification also passed before merge. All 11 substantive PR CI/security checks passed. CodeRabbit was rate-limited/skipped, not counted as substantive review.

Reviewed helpers were installed through Aymen's separately authorized main operator lane, with backups and validation; workers still cannot install their own boundary. Existing old-main CI and Scorecard runs were recovered successfully through the authorized operator credential. The broker rejects rerunning an already successful run; its positive/negative allowed-operation paths are covered by tests.

Deployment note: this OpenClaw runtime reads the global sandbox sessionToolsVisibility default, not the per-agent override. The default is configured to all while the cross-agent allowlist stays restricted to main/pd-owner. Only these three project agents are currently sandboxed; implementer/verifier lack session messaging/history/list tools. The owner's internal notify-only maintenance canary was admitted successfully. No gateway restart or protection bypass.

App activation still gates publishing; no package release is claimed. Post-merge checks are being monitored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant