Repository navigation
security: update supported MCP v1 dependency to 1.30.0 - #145
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Vision — automated project maintainer Independent verification (temporary credential): success Head: {
"head_sha": "afc32485ae5744dc7b6e8ad0e684488644516dac",
"base_sha": "10740c7d259ae8e7aa4fd8d9346f5cf3aa7acb5b",
"approved": true,
"summary": "Independent prepublication review passed. The complete diff changes only the MCP requirement from >=1.27.0 to >=1.30.0 and the corresponding lock entry; no transitive packages, source, tests, workflows, corpus, baseline, or policy changed. Upstream advisories confirm 1.28.1 is affected and 1.30.0 is patched, without establishing that HTTP-specific issues are reachable through this stdio server. All six registered tool contracts match the base. A fresh 1,603-document index produced identical base/head outcomes: 34 retrieval hits and 69 citations across 65 version-specific cases, with no regressions. The full suite had 570 passes and one skip; the skip is not a pass. The locked dependency audit found no known vulnerabilities. The head is unpublished and has zero hosted check runs; required CI remains pending and must pass before merge.",
"commands": [
{
"command": "git clone --filter=blob:none --no-checkout --depth=1 https://github.com/ayhammouda/python-docs-mcp-server.git repo",
"exit_code": 0
},
{
"command": "git fetch --depth=1 origin afc32485ae5744dc7b6e8ad0e684488644516dac",
"exit_code": 0
},
{
"command": "git fetch --depth=1 origin 10740c7d259ae8e7aa4fd8d9346f5cf3aa7acb5b",
"exit_code": 0
},
{
"command": "git checkout --detach afc32485ae5744dc7b6e8ad0e684488644516dac",
"exit_code": 0
},
{
"command": "git diff --find-renames 10740c7d259ae8e7aa4fd8d9346f5cf3aa7acb5b afc32485ae5744dc7b6e8ad0e684488644516dac -- pyproject.toml uv.lock",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv sync --locked --dev",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked ruff check src/ tests/ benchmarks/ ops/ .github/scripts/",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pyright src/ benchmarks/",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pytest --tb=short -q",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv lock --check",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv pip compile --quiet pyproject.toml -o /tmp/requirements-check.txt",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks validate-corpus --corpus docs/benchmarks/corpus.yml --schema docs/benchmarks/corpus.schema.json",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv build",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pytest tests/test_stdio_smoke.py tests/test_schema_snapshot.py tests/test_retrieval_regression.py -q",
"exit_code": 0
},
{
"command": "XDG_CACHE_HOME=/tmp/heimdall-afc3248-cache /usr/local/bin/uv run --locked python-docs-mcp-server build-index --versions 3.11,3.12,3.13",
"exit_code": 0
},
{
"command": "XDG_CACHE_HOME=/tmp/heimdall-afc3248-cache /usr/local/bin/uv run --locked python-docs-mcp-server doctor",
"exit_code": 0
},
{
"command": "XDG_CACHE_HOME=/tmp/heimdall-afc3248-cache /usr/local/bin/uv run --locked python-docs-mcp-server validate-corpus",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks.regression --index /tmp/heimdall-afc3248-cache/mcp-python-docs/index.db --output /tmp/heimdall-afc3248-head-regression.json",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks.regression --index /tmp/heimdall-afc3248-cache/mcp-python-docs/index.db --output /tmp/heimdall-afc3248-base-regression.json",
"exit_code": 0
},
{
"command": "cmp /tmp/heimdall-afc3248-schema-0.json /tmp/heimdall-afc3248-schema-1.json",
"exit_code": 0
},
{
"command": "/tmp/heimdall-afc3248-wheel-venv/bin/python -m pytest --import-mode=importlib /tmp/heimdall-afc3248-test_stdio_smoke.py -q",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv export --locked --format requirements-txt --all-groups --all-extras --no-emit-project --no-hashes --output-file /tmp/heimdall-afc3248-audit-all.txt",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv tool run --from pip-audit pip-audit --requirement /tmp/heimdall-afc3248-audit-all.txt --no-deps --disable-pip --progress-spinner off --format json",
"exit_code": 0
},
{
"command": "git diff --check 10740c7d259ae8e7aa4fd8d9346f5cf3aa7acb5b afc32485ae5744dc7b6e8ad0e684488644516dac",
"exit_code": 0
},
{
"command": "git ls-remote origin refs/heads/main",
"exit_code": 0
},
{
"command": "curl -LsS https://api.github.com/repos/ayhammouda/python-docs-mcp-server/commits/afc32485ae5744dc7b6e8ad0e684488644516dac/check-runs",
"exit_code": 0
}
],
"blockers": []
} |
|
Vision — automated project maintainer Merge decision for exact head Mandatory prepublication review and exact-head Scope remains the supported MCP v1 security maintenance only; no transitive changes or MCP v2 migration. Post-merge CI will be checked separately; this is not a release announcement. Outcome review: 2026-10-17, or sooner for a supported-v1 advisory/regression. |
Vision — automated project maintainer
Summary
Closes #140. Raise the MCP lower bound to
>=1.30.0,<2.0.0and lock 1.30.0. Onlypyproject.tomlanduv.lockchange; no transitive dependency changes. Vision explicitly approved this narrow dependency-field edit in #140. MCP v2 #123 remains a separate migration.Evidence
10740c7d259ae8e7aa4fd8d9346f5cf3aa7acb5b; local head:2b23177ec9e31e66db97f509d3cb93236651e1d0. Published broker head:afc32485ae5744dc7b6e8ad0e684488644516dac; tree matches the reviewed local implementation. Mandatory independent prepublication review passed (pdctl publishexit 0). Exact-head PR verification remains pending.Limitations and gates
Retained index is not a fresh source-pinned rebuild; developer evidence is Linux/Python 3.12 and SDK stdio, not named-client qualification or release evidence. Initial diagnostic-only schema assertion and missing uvx path were corrected with raw failures retained; no product tests weakened. Independent prepublication review, exact published-head verification, required CI and review triage must pass before merge. No release is announced. Outcome review 2026-10-17; revisit immediately for newer supported v1 or contract/retrieval regressions.
Acceptance checklist
Why this triggered supervisor review
The runtime dependency constraint in
pyproject.tomlchanged. Vision explicitly approved this narrow supported-v1 security maintenance in #140; MCP v2 remains out of scope.Verified merge and post-merge result
Vision — automated project maintainer: exact-head
pdctl verifyand gated SHA-matched merge succeeded forafc32485ae5744dc7b6e8ad0e684488644516dac. All 11 checks passed with no unresolved threads/findings. CodeRabbit skipped and is not independent review.GitHub proves merge/main
49d307b814d254961ee7a7392e4620aebd87d2e8. CI, Product quality, Security Audit, CodeQL and OpenSSF Scorecard all passed. Product quality performed a fresh index build. Independent review reports 570 passes and one skip, not 571 passes, with a fresh 1,603-document index preserving 34/65 hits and 69 citations. Developer results above are separate. No release was made.Exact-head verification · Merge decision