fix(cli): reject non-numeric ids in cdk acknowledge - #1844
Merged
aws-cdk-automation merged 1 commit intoAug 18, 2026
Conversation
`cdk acknowledge <id>` ran the argument through `Number()`, so a scoped construct warning id like `@aws-cdk/aws-ecs:minHealthyPercent` became `NaN` and was serialized as `null` into `acknowledged-issue-numbers` in cdk.context.json, corrupting the file while the warning still showed. Validate that the id is a numeric notice id and fail fast with a clear error otherwise, pointing users to acknowledge scoped construct warnings in code via `Annotations.of(scope).acknowledgeWarning()`. Fixes aws#248
lemon0333
had a problem deploying
to
integ-approval
August 18, 2026 06:53 — with
GitHub Actions
Failure
aws-cdk-automation
enabled auto-merge
August 18, 2026 06:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 90.32% 90.33%
=======================================
Files 80 80
Lines 12124 12134 +10
Branches 1716 1718 +2
=======================================
+ Hits 10951 10961 +10
Misses 1139 1139
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
cdk acknowledge <id>ran its argument throughNumber(), so a scoped construct warning id such as@aws-cdk/aws-ecs:minHealthyPercentbecameNaNand was serialized asnullintoacknowledged-issue-numbersincdk.context.json— corrupting the file, while the warning still displayed.cdk acknowledgeis for numeric notice IDs; scoped construct warnings are acknowledged in code viaAnnotations.of(scope).acknowledgeWarning('<id>'). This validates the id is a numeric notice id and fails fast with a clear, actionable error instead of silently writingnull:Numeric IDs are unchanged. Added unit tests (a scoped id throws and leaves the context uncorrupted; a non-numeric id throws) —
acknowledge.test.tspasses (3/3).Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license