guest_os_booting: enable secure boot firmware feature on aarch64#6904
guest_os_booting: enable secure boot firmware feature on aarch64#6904hholoubk wants to merge 2 commits into
Conversation
Extend ovmf_firmware_feature enable_secure_boot to aarch64 using libvirt's uefi-vars varstore firmware path. Gate the variant on libvirt 12.1+ and QEMU 10.2+ where the feature is available. Assisted-by: Auto (Cursor) (~90%) Signed-off-by: hholoubk <hholoubk@redhat.com>
|
Warning Review limit reached
More reviews will be available in 32 minutes and 19 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace nested aarch64: condition with explicit only/no aarch64 variant split, matching disable_secure_boot and cartesian guest arch selection. Assisted-by: Auto (Cursor) (~90%) Signed-off-by: hholoubk <hholoubk@redhat.com>
Summary
guest_os_booting.ovmf_firmware_feature.positive_test.enable_secure_bootto aarch64QEMU_EFI.qemuvars.fd+vars.secboot.jsonvarstore) instead of pflash OVMFovmf_firmware_feature.pyviais_qemu_function_supported()Test plan
avocado run --vt-type libvirt guest_os_booting.ovmf_firmware_feature.positive_test.enable_secure_boot— should pass unchangedSummary by CodeRabbit
Release Notes