Repository navigation
Integrate sessions into the framework/kernel - #776
Merged
Merged
Conversation
Blacksmoke16
added
component:framework
kind:feature
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Oct 20, 2026
…#776) ## Context Adds the required bundle configuration to wire the session logic into the framework. Namely the new argument resolver, and listener that'll handle creating the session/setting the cookie and such behind the scenes if enabled. ## Changelog - Add `framework.session` bundle configuration to enable sessions - Requests to a server started with an ssl_context are now considered secure - Add a `tls` argument to `AHTTP::Request.new`, which `AHTTP::Request#secure?` uses when the request did not come from a trusted proxy - Add `AHK::Listeners::Session` and `AHK::Controller::ValueResolvers::Session` to persist the AHTTP::Session of each request and provide it to controllers - Fix Username in various changelogs
PallasAthenaie
pushed a commit
to athena-framework/http
that referenced
this pull request
Oct 20, 2026
…#776) ## Context Adds the required bundle configuration to wire the session logic into the framework. Namely the new argument resolver, and listener that'll handle creating the session/setting the cookie and such behind the scenes if enabled. ## Changelog - Add `framework.session` bundle configuration to enable sessions - Requests to a server started with an ssl_context are now considered secure - Add a `tls` argument to `AHTTP::Request.new`, which `AHTTP::Request#secure?` uses when the request did not come from a trusted proxy - Add `AHK::Listeners::Session` and `AHK::Controller::ValueResolvers::Session` to persist the AHTTP::Session of each request and provide it to controllers - Fix Username in various changelogs
PallasAthenaie
pushed a commit
to athena-framework/http-kernel
that referenced
this pull request
Oct 20, 2026
…#776) ## Context Adds the required bundle configuration to wire the session logic into the framework. Namely the new argument resolver, and listener that'll handle creating the session/setting the cookie and such behind the scenes if enabled. ## Changelog - Add `framework.session` bundle configuration to enable sessions - Requests to a server started with an ssl_context are now considered secure - Add a `tls` argument to `AHTTP::Request.new`, which `AHTTP::Request#secure?` uses when the request did not come from a trusted proxy - Add `AHK::Listeners::Session` and `AHK::Controller::ValueResolvers::Session` to persist the AHTTP::Session of each request and provide it to controllers - Fix Username in various changelogs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adds the required bundle configuration to wire the session logic into the framework. Namely the new argument resolver, and listener that'll handle creating the session/setting the cookie and such behind the scenes if enabled.
Changelog
framework.sessionbundle configuration to enable sessionstlsargument toAHTTP::Request.new, whichAHTTP::Request#secure?uses when the request did not come from a trusted proxyAHK::Listeners::SessionandAHK::Controller::ValueResolvers::Sessionto persist the AHTTP::Session of each request and provide it to controllersBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title